Follow-up on #780 #784
Merged
Follow-up on #780 #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ke in our linker.
This comment has been minimized.
This comment has been minimized.
tristanlatr
commented
Apr 21, 2024
This comment has been minimized.
This comment has been minimized.
tristanlatr
commented
Apr 22, 2024
tristanlatr
commented
Apr 22, 2024
tristanlatr
commented
Apr 22, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #784 +/- ##
==========================================
- Coverage 92.67% 92.64% -0.04%
==========================================
Files 47 47
Lines 8373 8384 +11
Branches 1844 1848 +4
==========================================
+ Hits 7760 7767 +7
- Misses 353 355 +2
- Partials 260 262 +2 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
|
According to pydoctor_primer, this change doesn't affect pydoctor warnings on a corpus of open source code. ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the function to upgrade annotations. Respect annotations rules like in our linker.